Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Init licenses for test bindings (#81961)" #82337

Merged
merged 2 commits into from May 14, 2021
Merged

Revert "Init licenses for test bindings (#81961)" #82337

merged 2 commits into from May 14, 2021

Conversation

jiahaog
Copy link
Member

@jiahaog jiahaog commented May 12, 2021

This reverts commit b3f7ebe / #81961.

Context: #81961 (comment) - will revert this first and then follow up with tweaking the API.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels May 12, 2021
@google-cla google-cla bot added the cla: yes label May 12, 2021
@jiahaog jiahaog requested a review from Hixie May 12, 2021 11:29
@jiahaog
Copy link
Member Author

jiahaog commented May 14, 2021

@Hixie PTAL!

Hixie
Hixie approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jiahaog
Copy link
Member Author

jiahaog commented May 14, 2021

Google testing failures are unrelated, overriding

@fluttergithubbot fluttergithubbot merged commit 08154b2 into flutter:master May 14, 2021
@jiahaog jiahaog deleted the revert-license branch May 14, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiahaog @fluttergithubbot @Hixie